Skip to content

vimPlugins.render-markdown-nvim: remove unneeded nvim-treesitter dependency #344143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aleksanaa merged 1 commit into from
Sep 24, 2024
Merged

vimPlugins.render-markdown-nvim: remove unneeded nvim-treesitter dependency #344143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkgs/applications/editors/vim/plugins/overrides.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,11 +1501,6 @@ in
dependencies = with self; [ nvim-treesitter plenary-nvim ];
};

render-markdown-nvim = super.render-markdown-nvim.overrideAttrs {
dependencies = with self; [ nvim-treesitter ];
Copy link
Member

@PerchunPak PerchunPak Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be nvim-treesitter-parsers.markdown nvim-treesitter-parsers.latex?

Copy link
Contributor Author

@GaetanLepage GaetanLepage Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this wouldn't be enough to get the parsers "installed" properly.

Copy link
Member

@PerchunPak PerchunPak Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvim-treesitter.withPlugins just adds those to nvim-treesitter.passthru.dependencies, so it should be enough

Copy link
Contributor Author

@GaetanLepage GaetanLepage Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know.

nvimRequireCheck = "render-markdown";
};

# needs "http" and "json" treesitter grammars too
rest-nvim = super.rest-nvim.overrideAttrs {
dependencies = with self; [
Expand Down