python312Packages.kaleido: init at 0.2.1#339136
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
There was a problem hiding this comment.
This is the third attempt, as far as I know, but no one has been able to build it from the source.😢
Pandapip1
force-pushed
the
init-python3packages-kaleido
branch
4 times, most recently
from
4ce530b to
f30a433
Compare
Pandapip1
force-pushed
the
init-python3packages-kaleido
branch
from
6135aa7 to
8cf971e
Compare
Pandapip1
force-pushed
the
init-python3packages-kaleido
branch
3 times, most recently
from
9add00d to
a411299
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
eclairevoyant
changed the title
|
Also please use the full attrname in commits so that borgo knows what to build (i.e. |
Pandapip1
force-pushed
the
init-python3packages-kaleido
branch
from
a411299 to
78d34e5
Compare
|
Just noticed there weren't any maintainers for plotly, so this PR also has me adopting it. |
Pandapip1
added
the
0.kind: package adoption
|
please use python312Packages, not python3Packages, in the commit message. |
|
@ofborg build python312Packages.kaleido python311Packages.kaleido |
|
Tests fail on darwin with the following log. I suspect Details |
|
@natsukium in the meantime, I've marked the package as broken on darwin. Does that address that concern for the time being? |
|
I think it looks good. The darwin fix can be done in another PR. |
|
cc @GaetanLepage, @Sigmanificient if you're interested. |
Pandapip1
added
the
12.approvals: 1
|
Result of 10 packages marked as broken and skipped:
2 packages failed to build:
120 packages built:
|
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-339136-to-release-24.05 origin/release-24.05
cd .worktree/backport-339136-to-release-24.05
git switch --create backport-339136-to-release-24.05
git cherry-pick -x 25ad2d11ec45cbc6c908b78de63ad49aba401f9f 534c90d223c32bf88b7aba3399fa69936c25fbf6 46c1ce890a749f6c17b07ce87237e7ebccf5af42 6c9867637668f00d0e7f8dac0f3312c525500c9d 7edc3b600d3e35e422bed873b9956797aeec801b |
|
Manually backported: #339839 |
|
Here's a weirdness: it builds fine on Darwin when run as a stand-alone build. The error you saw (essentially "we don't know how to find the system UI configuration") may be due to the building machine being headless. Recommendation: disable the failing test. It passes when run on a desktop/laptop. |
|
It’s just the Nix sandbox forbidding access to OS stuff. Happens a lot. |
|
Unfortunately I don't have access to a darwin machine to debug this. I suspect it might be |
I think @emilazy has identified the issue. I'm attempting to verify it on a Darwin machine so we can disable the appropriate tests. |
Yea, I was just noting that |
|
I’m not sure what you mean; |
|
Loading libGL is done impurely in NixOS, because nvidia. |
|
I wouldn’t quite call that an impurity. Anyway, that’s not too relevant to macOS, where every system framework is built inside Nix against purely‐packaged stubs listing the available symbols, and which is then linked against the OS‐level framework code at runtime by the dynamic loader. (So in a sense, every system library is like |
|
I can't get the build to break for me on Darwin, even with sandboxing enabled. Should I file a PR that conditionally disables the passthrough test on Darwin and removes the |
Go right ahead! |
This package was introduced in NixOS#339136, which attracted quite a bit of conversation. I don't have the energy to go through the conversations but it looks like some low-hanging fruit got overlooked. This package depends on `sbcl` (!!) in order to get `fontconfig` files for `dejavu` (!!!), which is ... already in the default `pkgs.fontconfig` config files. This is a stripped-down version of NixOS#454818 to (hopefully) expedite its merge.
5 participants
Description of changes
I'm sorry, I literally couldn't figure out how to do a source build. If someone would like to figure it out for themselves, uh, good luck!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.