Skip to content

[Backport release-24.05] python312Packages.kaleido: init at 0.2.1#339839

Merged
emilazy merged 5 commits intoNixOS:release-24.05from
Pandapip1:backport-339136-to-release-24.05
Sep 6, 2024
Merged

[Backport release-24.05] python312Packages.kaleido: init at 0.2.1#339839
emilazy merged 5 commits intoNixOS:release-24.05from
Pandapip1:backport-339136-to-release-24.05

Conversation

@Pandapip1
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 5, 2024
@Pandapip1
Copy link
Member Author

Pandapip1 commented Sep 5, 2024

Had to resolve a merge conflict (in master, the with maintainers; [ ] was changed to remove the with maintainers;, leaving just [ ]), hence the cherry-picks / check fail:

Warning: Difference between 40918382dd994b2ece2ad042570031868221d155 and original 6c9867637668f00d0e7f8dac0f3312c525500c9d may warrant inspection:
1:  6c9867637668 ! 1:  40918382dd99 python312Packages.plotly: adopt
    @@ Metadata
      ## Commit message ##
         python312Packages.plotly: adopt
     
    +    (cherry picked from commit 6c9867637668f00d0e7f8dac0f3312c525500c9d)
    +
      ## pkgs/development/python-modules/plotly/default.nix ##
     @@ pkgs/development/python-modules/plotly/default.nix: buildPythonPackage rec {
          downloadPage = "https://github.com/plotly/plotly.py";
          homepage = "https://plot.ly/python/";
          license = with licenses; [ mit ];
    --    maintainers = [ ];
    +-    maintainers = with maintainers; [ ];
     +    maintainers = with maintainers; [ pandapip1 ];
        };
      }
Note this should not necessarily be treated as a hard fail, but a reviewer's attention should be drawn to it and github actions have no way of doing that but to raise a 'failure'

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 5, 2024
@emilazy emilazy merged commit a1a5238 into NixOS:release-24.05 Sep 6, 2024
@Pandapip1 Pandapip1 deleted the backport-339136-to-release-24.05 branch September 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants