python312Packages.numpy_2: 2.0.1 -> 2.1.0#336284
Merged
doronbehar merged 8 commits intoNixOS:masterfrom Aug 26, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
13 tasks
Contributor
Author
|
Nixfmt issues are because NixOS/nixfmt#224 is not released yet. |
ofborg
bot
added
10.rebuild-darwin: 101-500
Contributor
|
Result of 22 packages marked as broken and skipped:
202 packages failed to build:
12 packages built:
|
Contributor
|
Result of 22 packages marked as broken and skipped:
183 packages failed to build:
36 packages built:
|
Contributor
|
Result of 14 packages marked as broken and skipped:
197 packages failed to build:
44 packages built:
|
Contributor
|
Result of 56 packages marked as broken and skipped:
178 packages failed to build:
12 packages built:
|
Contributor
Author
|
Wow very impressive how you have all of these platforms :). Do all of these failure relate to the version of numba not supported? Can you give please an example of a build log failure? |
Contributor
Author
|
OK so the numba version issue is a bit annoying. I have a workaround ready for it, but I hope to not apply it and wait for a numba release. I'll put this as a draft. |
doronbehar
force-pushed
the
pkg/numpy.numba
branch
from
7bff4a4 to
aedabba
Compare
Contributor
I am using the community builders ! |
Contributor
|
This is the |
Contributor
Author
|
Building the following locally drains all memory from my machine and eventually fails... Not sure why, let's see ofborg dealing with it: @ofborg build python312Packages.numba.passthru.tests.withSandbox |
Add a temporary hack to pretend the version as 0.61.0dev0
doronbehar
force-pushed
the
pkg/numpy.numba
branch
from
2ae99da to
4865fc4
Compare
Contributor
Author
|
https://github.com/ofborg build python312Packages.numba.passthru.tests.withSandbox |
Contributor
|
Result of 26 packages marked as broken and skipped:
8 packages failed to build:
217 packages built:
|
Contributor
|
Result of 10 packages marked as broken and skipped:
12 packages failed to build:
237 packages built:
|
Contributor
Author
|
@ofborg build python312Packages.numba.passthru.tests.withSandbox |
Contributor
|
Result of 56 packages marked as broken and skipped:
30 packages failed to build:
164 packages built:
|
Contributor
|
Result of 28 packages marked as broken and skipped:
28 packages failed to build:
192 packages built:
|
Contributor
|
This seems to be in a pretty good state. Should it be marked as ready @doronbehar ? |
GaetanLepage
approved these changes
Aug 25, 2024
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Diff looks fine to me. Thanks !
dotlambda
reviewed
Sep 1, 2024
| buildInputs = lib.optionals cudaSupport [ cudaPackages.cuda_cudart ]; | ||
| buildInputs = [ | ||
| # Not propagating it, because it numba can work with either numpy_2 or numpy_1 | ||
| numpy_2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.