Revert "python312Packages.numba: use a single numpy version; don't propagate it"#338884
Revert "python312Packages.numba: use a single numpy version; don't propagate it"#338884dotlambda merged 2 commits intoNixOS:masterfrom
Conversation
natsukium
left a comment
There was a problem hiding this comment.
That PR also removed numpy from build-system.
7afe2d5 to
8fc50a5
Compare
…opagate it" This reverts commit 3bad188. Numba doesn't work without NumPy and it's in upstream's setup_requires as well as install_requires.
8fc50a5 to
9fe3c86
Compare
doronbehar
left a comment
There was a problem hiding this comment.
I'm sorry but I don't agree with this policy. If there was a single numpy version in all of python3.pkgs, we wouldn't have argued so much. If you'd be able to iterate all usages of numpy_1 and make sure that there are no breakages when that is upgraded to numpy_2, I will let it go.
There is, at least once this PR is merged. Every Python package uses
I already showed you how you'd make sure of that: #327446 (comment) @doronbehar Honestly, you're not engaging with my proposed solutions so I don't see why I should keep arguing against your non-solution. |
The Python maintainers disagree.
Description of changes
This reverts commit 3bad188.
Numba doesn't work without NumPy and it's in upstream's setup_requires as well as install_requires.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.