python312Packages.numba: fix compatibility with numpy 2.0.1#336281
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Aug 21, 2024
Merged
python312Packages.numba: fix compatibility with numpy 2.0.1#336281GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
Contributor
|
Looks good, but I wonder if it would be possible to make this compatible with numpy 2.1 although numba/numba#9708 ... I have a few questions from numba users: You use both numpy_2 and numpy_1 for the build... How does it work? I noticed that removing |
Contributor
|
My alternative: #336284 |
ofborg
bot
added
10.rebuild-darwin: 101-500
Contributor
Author
|
Result of 22 packages marked as broken and skipped:
26 packages failed to build:
181 packages built:
|
doronbehar
approved these changes
Aug 21, 2024
Contributor
doronbehar
left a comment
doronbehar
left a comment
There was a problem hiding this comment.
Can be merged in the meantime until a numba with numpy 2.1 support will be released.
Contributor
|
Ofborg's CI error with aarch64-linux is weird... How come it didn't fail for you @GaetanLepage locally? |
Contributor
Author
Good question... maybe it has just been flaky on hydra... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
numbagot broken by the latest numpy update.While waiting for the next release, this patch should let it build.
Upstream issue: numba/numba#9687
Upstream PR: numba/numba#9683
cc @doronbehar
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.