python312Packages.torch: test torch.compile#328661
Merged
SomeoneSerge merged 5 commits intoNixOS:masterfrom Jul 20, 2024
Merged
python312Packages.torch: test torch.compile#328661SomeoneSerge merged 5 commits intoNixOS:masterfrom
SomeoneSerge merged 5 commits intoNixOS:masterfrom
Conversation
…accommodate different python versions
…ult python package sets
Contributor
|
btw torch.compile works for cpu, but not for gpu rn |
Contributor
Author
You mean master or the triton PR? |
Contributor
|
master |
SomeoneSerge
commented
Jul 20, 2024
Contributor
Author
There was a problem hiding this comment.
I switched from writers.writePython3Bin to a simple runCommand because it was easier to override python3Packages this way. Either way I'll keep editing this thing
Contributor
|
Possibly broke eval failure as: |
13 tasks
Contributor
|
Proposed the trivial change as #329511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds tests (including GPU/runtime checks) to document the premises for #328247
Status:
.#python311Packages.torch.tests.compileCpu.#python312Packages.torch.tests.compileCpu("Dynamo is not supported on Python 3.12+").#python3Packages.torch.tests.tester-compileCuda.gpuCheck("Dynamo is not supported on Python 3.12+").#python311Packages.torch.tests.tester-compileCuda.gpuCheck("ImportError: cannot import name 'get_cuda_version_key' from 'triton.common.backend'"); this functionality was working at the time of merging python3Packages.openai-triton: fix triton.common.build #325843Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.