python3Packages.openai-triton: fix triton.common.build#325843
Merged
SomeoneSerge merged 1 commit intoNixOS:masterfrom Jul 9, 2024
Merged
python3Packages.openai-triton: fix triton.common.build#325843SomeoneSerge merged 1 commit intoNixOS:masterfrom
SomeoneSerge merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
SomeoneSerge
changed the title
Contributor
|
@ofborg build python3Packages.torch |
SomeoneSerge
reviewed
Jul 9, 2024
| --replace "include(GoogleTest)" "find_package(GTest REQUIRED)" | ||
|
|
||
| cat << \EOF > python/triton/common/build.py | ||
|
|
Contributor
There was a problem hiding this comment.
The linefeed was intentional but let's keep your current version so as not to restart ofborg
Contributor
Author
There was a problem hiding this comment.
ahh oops, sorry about that.
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #325609 by appending to
triton.common.buildmodule instead of overwriting. CC @SomeoneSergeThings done
added an
>nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.