python3Packages.torch-bin: gpuChecks -> tests.tester-<name>.gpuCheck#325222
Merged
SomeoneSerge merged 1 commit intoNixOS:masterfrom Jul 7, 2024
Merged
python3Packages.torch-bin: gpuChecks -> tests.tester-<name>.gpuCheck#325222SomeoneSerge merged 1 commit intoNixOS:masterfrom
SomeoneSerge merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
SomeoneSerge
force-pushed
the
fix/gpu-access/torch-bin
branch
from
a288df3 to
3eff201
Compare
ofborg
bot
added
10.rebuild-darwin: 0
trofi
approved these changes
Jul 7, 2024
Contributor
trofi
left a comment
trofi
left a comment
There was a problem hiding this comment.
Fixed the eval for me. Thank you!
Contributor
|
EDIT: moved to more likely #328661 (comment) culprit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As noted in #256230 (comment) (CC @trofi), in the last moment refactor (79a7186) I moved the runtime checks around in
python3Packages.torch, but I didn't updatepython3Packages.torch-binwhich now causes evaluation errors.This change should remove eval errors and make for a slightly more coherent layout...
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.