clever-tools: fix cleanup for cross compilation#327207
Merged
fpletz merged 1 commit intoNixOS:masterfrom Jul 20, 2024
Merged
Conversation
philiptaron
approved these changes
Jul 14, 2024
ofborg
bot
added
6.topic: cross-compilation
florian-sanders-cc
approved these changes
Jul 15, 2024
Contributor
There was a problem hiding this comment.
@SFrijters Sorry you didn't get the chance to raise this issue (or that I did not handle this properly) before it got merged but thanks a lot for handling this 👍
wegank
added
the
12.approvals: 2
fpletz
approved these changes
Jul 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#326039 was merged before this issue was addressed.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.