Skip to content

zathura-pdf-mupdf: 0.4.2 -> 0.4.3#325136

Closed
laalsaas wants to merge 2 commits intoNixOS:masterfrom
laalsaas:zathura-pdf-mupdf-0-4-3
Closed

zathura-pdf-mupdf: 0.4.2 -> 0.4.3#325136
laalsaas wants to merge 2 commits intoNixOS:masterfrom
laalsaas:zathura-pdf-mupdf-0-4-3

Conversation

@laalsaas
Copy link
Contributor

@laalsaas laalsaas commented Jul 6, 2024

Description of changes

This PR also contains a mupdf update, which is needed for the new version of zathura-pdf-mupdf.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Cflags: -I\''${includedir}
EOF

ln -s $out/lib/libmupdf.so.24.5 $out/lib/libmupdf.so
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a more elegant way of doing this

@ofborg ofborg bot requested review from fpletz and vrthra July 7, 2024 00:07
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 7, 2024
@eclairevoyant eclairevoyant marked this pull request as draft July 7, 2024 00:39
@eclairevoyant
Copy link
Contributor

eclairevoyant commented Jul 7, 2024

should probably go to staging due to the red labels?

also, #298783 is open for the mupdf bump, please take a look at the feedback there to make sure those issues aren't present here

@smancill
Copy link
Contributor

smancill commented Aug 26, 2024

#337383 bumps to 0.4.4, just waiting for mupdf 1.24 to be on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants