Skip to content

zathura: 0.5.6 -> 0.5.8, all plugins updated#337383

Merged
fpletz merged 2 commits intoNixOS:masterfrom
smancill:update-zathura-and-plugins
Sep 5, 2024
Merged

zathura: 0.5.6 -> 0.5.8, all plugins updated#337383
fpletz merged 2 commits intoNixOS:masterfrom
smancill:update-zathura-and-plugins

Conversation

@smancill
Copy link
Contributor

@smancill smancill commented Aug 26, 2024

Description of changes

Update zathura and plugins.

For the plugins, their data/meson.build now requires desktop-file-utils (for desktop-file-validate) and appstream-glib (for appstream-util). Or the alternative is to patch the required: get_option('tests') argument for find_program.

Supersedes #325136.

Closes #334368 (last release is 0.4.4)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@smancill
Copy link
Contributor Author

smancill commented Aug 26, 2024

Making it a draft for now until mupdf 1.24 is available on master. Or should I go to staging?

@smancill smancill marked this pull request as draft August 26, 2024 02:58
@smancill smancill mentioned this pull request Aug 26, 2024
13 tasks
@smancill smancill changed the title zathura: 0.5.6 -> 0.5.8 zathura: 0.5.6 -> 0.5.8, all plugins updated Aug 26, 2024
@smancill smancill self-assigned this Aug 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 26, 2024
@smancill smancill force-pushed the update-zathura-and-plugins branch from c0fa15d to 5a1221d Compare August 31, 2024 01:05
@smancill smancill marked this pull request as ready for review September 2, 2024 03:37
@smancill
Copy link
Contributor Author

smancill commented Sep 2, 2024

@ofborg build zathura

@smancill
Copy link
Contributor Author

smancill commented Sep 2, 2024

Result of nixpkgs-review pr 337383 run on x86_64-darwin 1

2 packages built:
  • vimPlugins.openscad-nvim
  • zathura

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4502

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fails to build

Dependency mupdf found: NO. Found 1.23.6 but need: '>=1.24'
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency mupdf found: NO (tried pkgconfig and cmake)
Has header "mupdf/fitz/version.h" : YES 
Has header "mupdf/fitz.h" : YES 
Has header "mupdf/pdf.h" : YES 
Library mupdf found: YES
meson.build:45:4: ERROR: Problem encountered: mupdf 1.24 or newer is required
A full log can be found at /build/zathura-pdf-mupdf-0.4.4/build/meson-logs/meson-log.txt
error: builder for '/nix/store/bvc3qjc4jrf7lndwlr0g00yw8wsscffv-zathura-pdf-mupdf-0.4.4.drv' failed with exit code 1;

Also it would be better to do each update in its own commit. Then ofborg would also build all packages.

Plugins are also updated to latest version.
@smancill smancill force-pushed the update-zathura-and-plugins branch from 5a1221d to b5fae88 Compare September 4, 2024 00:31
@smancill
Copy link
Contributor Author

smancill commented Sep 4, 2024

It works, but it just needed a rebase. The nixpkgs-review does the merge so that's why it worked too.

@fpletz fpletz merged commit 30fb59d into NixOS:master Sep 5, 2024
@smancill smancill deleted the update-zathura-and-plugins branch September 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update request: zathura-pdf-mupdf 0.4.2 → 0.4.4

4 participants