zathura: 0.5.6 -> 0.5.8, all plugins updated#337383
Merged
fpletz merged 2 commits intoNixOS:masterfrom Sep 5, 2024
Merged
Conversation
Contributor
Author
|
Making it a draft for now until mupdf 1.24 is available on |
13 tasks
c0fa15d to
5a1221d
Compare
Contributor
Author
|
@ofborg build zathura |
Contributor
Author
|
Result of 2 packages built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4502 |
SuperSandro2000
previously requested changes
Sep 3, 2024
Member
There was a problem hiding this comment.
fails to build
Dependency mupdf found: NO. Found 1.23.6 but need: '>=1.24'
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency mupdf found: NO (tried pkgconfig and cmake)
Has header "mupdf/fitz/version.h" : YES
Has header "mupdf/fitz.h" : YES
Has header "mupdf/pdf.h" : YES
Library mupdf found: YES
meson.build:45:4: ERROR: Problem encountered: mupdf 1.24 or newer is required
A full log can be found at /build/zathura-pdf-mupdf-0.4.4/build/meson-logs/meson-log.txt
error: builder for '/nix/store/bvc3qjc4jrf7lndwlr0g00yw8wsscffv-zathura-pdf-mupdf-0.4.4.drv' failed with exit code 1;
Also it would be better to do each update in its own commit. Then ofborg would also build all packages.
Plugins are also updated to latest version.
5a1221d to
b5fae88
Compare
Contributor
Author
|
It works, but it just needed a rebase. The nixpkgs-review does the merge so that's why it worked too. |
fpletz
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Update zathura and plugins.
masterbrowsr: 1.19.0 -> 1.21.0, mupdf: 1.23.6 -> 1.24.8, python312Packages.pymupdf: 1.23.6 -> 1.24.8, python312Packages.textual-universal-directory: 1.1.0 -> 1.5.0 #332385)For the plugins, their
data/meson.buildnow requiresdesktop-file-utils(fordesktop-file-validate) andappstream-glib(forappstream-util). Or the alternative is to patch therequired: get_option('tests')argument forfind_program.Supersedes #325136.
Closes #334368 (last release is 0.4.4)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.