mupdf: 1.23.6 -> 1.24.0

[dotlambda]

Description of changes

Changelog: https://git.ghostscript.com/?p=mupdf.git;a=blob_plain;f=CHANGES;hb=1.24.0

cc #298509

fixes #298551

closes #274882
closes #290651

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

cc @stuebinm

---

Add a 👍 reaction to pull requests you find important.

[dotlambda]

pymupdf import fails with

Traceback (most recent call last):
  File "/nix/store/inmx8af946vr0lnvrcjd393mxh54sqbp-python3.11-pymupdf-1.24.0/lib/python3.11/site-packages/fitz/extra.py", line 14, in swig_import_helper
    return importlib.import_module(mname)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/7wz6hm9i8wljz0hgwz1wqmn2zlbgavrq-python3-3.11.8/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 676, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 573, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1233, in create_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
ImportError: libmupdfcpp.so.24.0: cannot open shared object file: No such file or directory

Help is appreciated!

[l0b0]

LGTM, untested (I never used this package directly).

Thank you!

[lilyinstarlight]

You need env.USE_SONAME = "no", the python wrap script doesn't get the memo otherwise and that is (indirectly) causing the pymupdf imports to fail

There's also pymupdf test failures, but I don't have time to dig further right now

[dotlambda]

Do you have an idea why https://github.com/ArtifexSoftware/mupdf/blob/1.24.0/Makefile#L644 doesn't have an effect? The non-version shared library is supposed to be created even without setting USE_SONAME=no.

[lilyinstarlight]

The makefile gets the memo, but this snippet does not: https://github.com/ArtifexSoftware/mupdf/blob/1.24.0/scripts/wrap/__main__.py#L1165-L1166

If you don't use the env var, then the libmupdfcpp.so file gets a SONAME that does not exist because the makefile does not link it

[lilyinstarlight]

(it sets soname via linker arg here: https://github.com/ArtifexSoftware/mupdf/blob/1.24.0/scripts/wrap/__main__.py#L1716 and pymupdf uses soname over filename here: https://github.com/pymupdf/PyMuPDF/blob/1.24.0/setup.py#L638 and https://github.com/pymupdf/PyMuPDF/blob/1.24.0/pipcl.py#L2267)

[dotlambda]

@lilyinstarlight Let me express myself more clearly. If I don't set USE_SONAME=no I expect there to be a versioned shared library and a non-versioned link to it, because of the makefile snippet I shared above. However that link is never created. I don't understand why.

[lilyinstarlight]

@lilyinstarlight Let me express myself more clearly. If I don't set USE_SONAME=no I expect there to be a versioned shared library and a non-versioned link to it, because of the makefile snippet I shared above. However that link is never created. I don't understand why.

Ohhh, yeah that's because it's not added in the postInstall, apologies for misunderstanding 😅

nixpkgs/pkgs/applications/misc/mupdf/default.nix

Line 170 in 4a3db5a

cp build/*/libmupdfcpp.so $out/lib

[dotlambda]

But shouldn't https://github.com/ArtifexSoftware/mupdf/blob/1.24.0/Makefile#L644 already do that?

[lilyinstarlight]

We don't use the makefile to install the cpp lib because make target dependencies try to rebuild everything as not-shared iirc

[dotlambda]

I'm talking about libmupdf.so, not libmupdfcpp.so.

[lilyinstarlight]

Ah, I really shouldn't be computering when I'm so tired... the makefile doesn't seem to use the install-shared-c target when doing make install and the install-libs target doesn't create the link by itself: https://github.com/ArtifexSoftware/mupdf/blob/1.24.0/Makefile#L478

[sdht0]

Are you able to build pymupdf? Tests are still failing for me.

[SuperSandro2000]

FYI #332385

[thiagokokada]

Fixed by #332385.