Skip to content

pidginPackages: re-add recurseIntoAttrs#330220

Merged
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/pidginPackages-fix
Jul 27, 2024
Merged

pidginPackages: re-add recurseIntoAttrs#330220
infinisil merged 1 commit intoNixOS:masterfrom
philiptaron:__attrsFailEvaluation/pidginPackages-fix

Conversation

@philiptaron
Copy link
Contributor

Description of changes

I erroneously removed this in 3abc5f7 (part of PR #323867).

https://hydra.nixos.org/eval/1807900?compare=1807880#tabs-removed

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

This was erroneously removed in 3abc5f7
@philiptaron philiptaron requested a review from vcunat July 26, 2024 17:23
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (but why not wait for ofborg eval)

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 26, 2024
@philiptaron
Copy link
Contributor Author

Looks good. (but why not wait for ofborg eval)

It now passed 🎉

@philiptaron philiptaron requested a review from infinisil July 27, 2024 03:51
@infinisil infinisil merged commit b772e94 into NixOS:master Jul 27, 2024
@infinisil
Copy link
Member

@vcunat I'm just on my phone right now, but from what I can see, ofborg did succeed in the original PR. The problem here seems to have not been an eval failure, but rather the accidental removal of some Hydra jobs (see PR description)

@vcunat
Copy link
Member

vcunat commented Jul 27, 2024

I didn't mean to imply there was any eval failure.

@philiptaron philiptaron deleted the __attrsFailEvaluation/pidginPackages-fix branch July 27, 2024 06:02
@infinisil
Copy link
Member

@vcunat Ah I see, I misunderstood your comment, all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants