[23.11] Backport Electron updates, init electron_29, init electron_28-bin, init electron_29-bin#301322
Merged
drupol merged 5 commits intoNixOS:release-23.11from Apr 7, 2024
Conversation
ofborg
bot
added
8.has: package (new)
Member
Author
|
Looks like a few fixes from ea0df4c will be required for this to build. |
Contributor
|
Indeed I'd assume that as much as possible should be backported, ideally making auto-backports possible for future updates again |
- provide passthru.fetchedDeps for debugging - adapt gn args for latest electron versions - fix mechanism for applying patches for latest electron versions (cherry picked from commit 9f26152)
Member
Author
|
@yu-re-ka does the build just fail because it takes too long? EDIT: also I had one doubt about |
Member
Author
|
Result of 1 package built:
|
Member
Author
Contributor
|
Ofborg is too slow to build electron |
Member
Author
It took 3h on my AMD machine 😅 |
Member
Author
|
@yu-re-ka ready for review. Anything missing here from your perspective? |
teutat3s
added
the
1.severity: security
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Partial backport of #295672.
This is required to merge #300741. The pinned electron version stays the same, only new versions are introduced.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.