Electron updates#295672
Merged
yu-re-ka merged 7 commits intoNixOS:masterfrom Mar 14, 2024
yu-re-ka:electron-29
Merged
Conversation
ofborg
bot
added
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
Built electron_27, electron_28 on x86_64-linux |
13 tasks
- provide passthru.fetchedDeps for debugging - adapt gn args for latest electron versions - fix mechanism for applying patches for latest electron versions
Member
|
Result of 1 package failed to build:
57 packages built:
|
1 task
Member
|
@yu-re-ka Do you have time to backport electron 29? |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-295672-to-release-23.11 origin/release-23.11
cd .worktree/backport-295672-to-release-23.11
git switch --create backport-295672-to-release-23.11
git cherry-pick -x 06227618a1381eab4a2f10ec11dc9e5c0e7feeb6 f3fb7b5980cdc8e93d9a0ee0e9a4e58c451a9ff8 806db42d25e1a95234dd6d87c0eb71e9001913ea f5dc5df8d46a5681a84684a6512851b2264a1d76 c45702dfc951818ae096aafc34b0eea990bc9a36 1f9c426744ca908110a8ab392352c843ca07a7c3 ea0df4c23b0c18cee92c2497ef04892e7d0febad |
13 tasks
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.