electron: support v29 binary option#296218
Merged
yu-re-ka merged 1 commit intoNixOS:masterfrom Mar 16, 2024
Merged
Conversation
Contributor
Author
|
I built and tested this on both Darwin architectures by way of Bruno which requires Electron and happens to be part of my current nix-darwin systems. |
ofborg
bot
added
8.has: package (new)
Contributor
Author
|
Result of 1 package failed to build:
12 packages built:
The failing package ( |
Contributor
Author
|
@yu-re-ka would you be interested in reviewing this PR? |
mattpolzin
force-pushed
the
electron-29-binary
branch
from
28ad15e to
9582ebf
Compare
Contributor
Author
Ah, thanks! |
Contributor
Author
|
Result of 1 package failed to build:
12 packages built:
|
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-296218-to-release-23.11 origin/release-23.11
cd .worktree/backport-296218-to-release-23.11
git switch --create backport-296218-to-release-23.11
git cherry-pick -x 9582ebf3c48c740544e42fceac71c2af10838a13 |
teutat3s
pushed a commit
to teutat3s/nixpkgs
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit 428564f)
zeme-wana
pushed a commit
to input-output-hk/nixpkgs
that referenced
this pull request
May 8, 2024
(cherry picked from commit 428564f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add binary support for newest Electron version. Electron binary support is important for Darwin systems currently.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.