Skip to content

Comments

llvmPackages_git: move everything to common#299807

Closed
RossComputerGuy wants to merge 11 commits intoNixOS:masterfrom
ExpidusOS:feat/llvm-git-commonify
Closed

llvmPackages_git: move everything to common#299807
RossComputerGuy wants to merge 11 commits intoNixOS:masterfrom
ExpidusOS:feat/llvm-git-commonify

Conversation

@RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Mar 28, 2024

Description of changes

This PR moves all packages from pkgs/development/compilers/llvm/git into pkgs/development/compilers/llvm/common. This makes the upgrade process simpler for git and packaging a new LLVM version will be more straight forward. We'll also have less redundant files.

Things done

Progress:

  • lld
  • clang
  • compiler-rt
  • libcxx
  • libunwind
  • llvm
  • openmp
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 28, 2024
@RossComputerGuy RossComputerGuy marked this pull request as ready for review March 28, 2024 18:31
@RossComputerGuy RossComputerGuy marked this pull request as draft April 5, 2024 04:23
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify branch 2 times, most recently from 4030aba to f6e155c Compare April 5, 2024 04:35
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Apr 5, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 5, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify branch 3 times, most recently from f555ab9 to 959ef19 Compare April 7, 2024 05:17
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify branch 5 times, most recently from ab0c2b2 to 6dfac01 Compare April 11, 2024 04:46
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Apr 11, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify branch from 6dfac01 to 7ffb2c3 Compare April 11, 2024 05:40
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 11, 2024
@wegank
Copy link
Member

wegank commented Apr 11, 2024

It looks like there are already a few LLVM subprojects moved to common. If you wish, you can open separate PRs for them to speed up reviews and merges.

@RossComputerGuy
Copy link
Member Author

It looks like there are already a few LLVM subprojects moved to common. If you wish, you can open separate PRs for them to speed up reviews and merges.

Good idea.

@RossComputerGuy
Copy link
Member Author

lld has been split into #303438, going to keep this PR open until I finish splitting everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants