Skip to content

Comments

llvmPackages_{12,13,14,15,16,17,18,git}: use common libcxx#303449

Merged
wegank merged 1 commit intoNixOS:masterfrom
ExpidusOS:feat/llvm-git-commonify-libcxx
Apr 13, 2024
Merged

llvmPackages_{12,13,14,15,16,17,18,git}: use common libcxx#303449
wegank merged 1 commit intoNixOS:masterfrom
ExpidusOS:feat/llvm-git-commonify-libcxx

Conversation

@RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Apr 11, 2024

Description of changes

Partial split from #299807

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-libcxx branch from 862743e to 165ebfc Compare April 11, 2024 20:45
@RossComputerGuy RossComputerGuy changed the title llvmPackages_{12,git}: use common libcxx llvmPackages_{12,13,git}: use common libcxx Apr 11, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-libcxx branch from 165ebfc to f22c565 Compare April 11, 2024 21:13
@RossComputerGuy RossComputerGuy changed the title llvmPackages_{12,13,git}: use common libcxx llvmPackages_{12,13,14,15,16,17,18,git}: use common libcxx Apr 11, 2024
@RossComputerGuy RossComputerGuy marked this pull request as ready for review April 11, 2024 21:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 11, 2024
@RossComputerGuy
Copy link
Member Author

RossComputerGuy commented Apr 11, 2024

Idk what ofborg is on about, I used diff on nix derivation show between upstream and this PR and everything matches 1:1, including git. For whatever reason, it thinks something changed.

@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-libcxx branch from f22c565 to 15b7004 Compare April 12, 2024 00:21
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-libcxx branch 3 times, most recently from 8cf1359 to edfcdbd Compare April 12, 2024 21:05
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-libcxx branch from edfcdbd to 782fc2e Compare April 12, 2024 22:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 12, 2024
@wegank wegank merged commit e65e742 into NixOS:master Apr 13, 2024
@RossComputerGuy RossComputerGuy deleted the feat/llvm-git-commonify-libcxx branch April 13, 2024 14:32
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants