Skip to content

Comments

llvmPackages_{12,13,14,15,16,17,18,git}: use common clang#303506

Closed
RossComputerGuy wants to merge 1 commit intoNixOS:masterfrom
ExpidusOS:feat/llvm-git-commonify-clang
Closed

llvmPackages_{12,13,14,15,16,17,18,git}: use common clang#303506
RossComputerGuy wants to merge 1 commit intoNixOS:masterfrom
ExpidusOS:feat/llvm-git-commonify-clang

Conversation

@RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Apr 12, 2024 •
edited
Loading

Description of changes

Partial split from #299807

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 12, 2024
@RossComputerGuy RossComputerGuy changed the title llvmPackages_{12,13,14,15,16,17,18,git}: move clang to common llvmPackages_{12,13,14,15,16,17,18,git}: use common clang Apr 12, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-clang branch 2 times, most recently from 88ac3ec to a6c2c16 Compare April 12, 2024 20:45
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 12, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-clang branch from a6c2c16 to f3fa7c5 Compare April 12, 2024 21:03
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 12, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-clang branch from f3fa7c5 to 30839e1 Compare April 12, 2024 21:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 12, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 13, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-clang branch from 30839e1 to f49feb1 Compare April 14, 2024 01:56
@github-actions github-actions bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: lib The Nixpkgs function library labels Apr 14, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-clang branch from f49feb1 to 724c27d Compare April 14, 2024 01:58
@github-actions github-actions bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: lib The Nixpkgs function library labels Apr 14, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-clang branch from 724c27d to dc4d5c2 Compare April 14, 2024 02:01
@winterqt
Copy link
Member

winterqt commented Apr 14, 2024

Please open a new PR due to the mass-ping.

@winterqt winterqt closed this Apr 14, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 14, 2024
@NixOS NixOS locked and limited conversation to collaborators Apr 14, 2024
@RossComputerGuy RossComputerGuy deleted the feat/llvm-git-commonify-clang branch April 14, 2024 02:55
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@lovek323 lovek323 Awaiting requested review from lovek323

@alyssais alyssais Awaiting requested review from alyssais

@rrbutani rrbutani Awaiting requested review from rrbutani

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

@mweinelt mweinelt Awaiting requested review from mweinelt

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

@figsoda figsoda Awaiting requested review from figsoda

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@marsam marsam Awaiting requested review from marsam

@winterqt winterqt Awaiting requested review from winterqt

@FRidh FRidh Awaiting requested review from FRidh

@h7x4 h7x4 Awaiting requested review from h7x4

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RossComputerGuy @winterqt @rrbutani @wegank