swift: don't pass -march to swiftc#296082
Merged
1 commit merged intomasterfrom Mar 17, 2024
unknown repository
Merged
Conversation
ofborg
bot
requested review from
Ericson2314,
RaitoBezarius,
alyssais,
dtzWill,
lovek323,
rrbutani and
sternenseemann
ofborg
bot
added
10.rebuild-darwin: 0
ghost
marked this pull request as ready for review
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
changed the title
Author
|
@ofborg build swiftPackages.swift-unwrapped swiftPackages.Dispatch |
ghost
marked this pull request as draft
swiftc uses cc-wrapper which sets the -march flag on some systems which breaks the build. This change adds a flag, disableMarch, to cc-wrapper which disables using the -march flag. #295322
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
13 tasks
wegank
approved these changes
Mar 17, 2024
YorikSar
added a commit
to YorikSar/nixpkgs
that referenced
this pull request
Mar 18, 2024
Use the same stdenv and clang as part of it as Swift uses. Leverages workaround from NixOS#296082 for the issue NixOS#295322.
13 tasks
Contributor
|
Note that this needs to be propagated to downstream packages using Swift, for example #296878. |
Author
that's not good. so this change fixed the swift build but all downstream packages are still broken. will need to find a better solution. |
ghost
mentioned this pull request
13 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
adds an argument to cc-wrapper to disable setting
-march.fix #295322
no rebuild for x64 linux or darwin. aarch64 darwin build now succeeds.
https://hydra.nixos.org/build/253076388
https://hydra.nixos.org/build/253181970
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.