Conversation
ghost
reviewed
Apr 3, 2024
This reverts commit 8a7841c.
Member
|
Haven't reviewed in depth because I don't know about swift, but I like the approach. -march tells the compiler to optimise for a specific architecture, so we probably want it for Swift. |
|
@ofborg build swift |
ghost
approved these changes
Apr 3, 2024
|
x64/aarch64 darwin builds pass on community builder (ofborg timesout) |
13 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the
-Xccflag before the-marchflag passed toswiftc.#291901 changed how clang got the
-marchflag, which caused swiftc to get that flag as well. However, swiftc needs-Xccbefore-marchbecause it's a clang flag, not a swift flag.We could also simply prevent the
-marchflag from being passed to swiftc. I'm not familiar with exactly what this flag does, so I'm choosing to leave it in. However, note that #291901 seems to only have intended to add this flag to clang and accidentally added it to Swift, so maybe we do just want to remove it.I know adding
-Xccmade Swift able to build one of my Swift packages on aarch64-darwin, and I assume removing the flag will as well.Closes #295322.
May supercede #296082.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.