Skip to content

Comments

dark-mode-notify: sync clang with swift itself#296878

Merged
domenkozar merged 1 commit intoNixOS:masterfrom
YorikSar:dark-mode-notify-clang-fix
Mar 18, 2024
Merged

dark-mode-notify: sync clang with swift itself#296878
domenkozar merged 1 commit intoNixOS:masterfrom
YorikSar:dark-mode-notify-clang-fix

Conversation

@YorikSar
Copy link
Contributor

Description of changes

Use the same stdenv and clang as part of it as Swift uses. Leverages workaround from #296082 for the issue #295322.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Use the same stdenv and clang as part of it as Swift uses. Leverages
workaround from NixOS#296082 for
the issue NixOS#295322.
@YorikSar YorikSar mentioned this pull request Mar 18, 2024
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 18, 2024
@domenkozar domenkozar merged commit 9f904a1 into NixOS:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants