pytestCheckHook: ignore warnings by default#292350
Open
SuperSandro2000 wants to merge 2 commits intoNixOS:stagingfrom
Open
pytestCheckHook: ignore warnings by default#292350SuperSandro2000 wants to merge 2 commits intoNixOS:stagingfrom
SuperSandro2000 wants to merge 2 commits intoNixOS:stagingfrom
Conversation
github-actions
bot
added
6.topic: python
13 tasks
SuperSandro2000
force-pushed
the
pytest-ignore-warning
branch
from
59bf1f9 to
450d239
Compare
ofborg
bot
added
10.rebuild-darwin-stdenv
FRidh
suggested changes
Mar 1, 2024
Member
FRidh
left a comment
FRidh
left a comment
There was a problem hiding this comment.
Commit message lacks a motivation.
wegank
added
the
2.status: merge conflict
l0b0
reviewed
Nov 26, 2024
Contributor
l0b0
left a comment
l0b0
left a comment
There was a problem hiding this comment.
Why ignore warnings by default? The usual long-term result is just more (easily avoidable) errors.
|
|
||
| # Compose arguments | ||
| args=" -m pytest" | ||
| if [ -n "$dontIgnoreWarnings-}" ]; then |
Contributor
There was a problem hiding this comment.
This reads as "if not empty don't ignore warnings", which is a lot of negatives. Would if [ -z "$showWarnings-}" ] (which can be read as "if empty show warnings") be possible instead?
wegank
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.