Skip to content

More Python 3.12 enablement (home-assistant edition)#289893

Merged
mweinelt merged 32 commits intoNixOS:stagingfrom
mweinelt:home-assistant-on-3.12
Feb 24, 2024
Merged

More Python 3.12 enablement (home-assistant edition)#289893
mweinelt merged 32 commits intoNixOS:stagingfrom
mweinelt:home-assistant-on-3.12

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 19, 2024 •
edited
Loading

Description of changes

Reverting the pbr disable for 3.12 unblocks lots of packages, which of course need lots of attention. 🤷

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 19, 2024
@mweinelt mweinelt force-pushed the home-assistant-on-3.12 branch from 7cf4e51 to 00bb0c8 Compare February 19, 2024 04:16
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 19, 2024
SuperSandro2000
SuperSandro2000 reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of writing comments for all my nits and the switches to pynose and putting the work on you, I've opted into doing it myself and pushed it onto the branch. I've built all the packages locally on this branch and verified that things still work. The diff can be found here https://github.com/NixOS/nixpkgs/compare/03da39652278fa3168d326c5be28c8302b493064..9d42fd66e470ecf2b1d45ac904dae68de1916bd0
I hope that's fine for you.
Please consider everything up to this point reviewed and approved by me.

pkgs/development/python-modules/pytest-benchmark/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated note: we should probably set this in pytestCheckHook because I don't think we could be bothered less by those.

Copy link
Member Author

@mweinelt mweinelt Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to send a PR.

Copy link
Member

@SuperSandro2000 SuperSandro2000 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#292350

@mweinelt mweinelt force-pushed the home-assistant-on-3.12 branch from 22444c2 to d1f08b8 Compare February 19, 2024 18:03
@mweinelt
Copy link
Member Author

mweinelt commented Feb 19, 2024

Extracted the opencv bump into #289994 for more review.

@mweinelt mweinelt marked this pull request as ready for review February 19, 2024 20:45
@mweinelt mweinelt force-pushed the home-assistant-on-3.12 branch from d1f08b8 to 46be9cd Compare February 19, 2024 21:39
@mweinelt
Copy link
Member Author

mweinelt commented Feb 19, 2024 

❯ ./maintainers/scripts/rebuild-amount.sh origin/staging-next
Estimating rebuild amount by counting changed Hydra jobs (parallel=unset).
      1 pkgs-lib-tests
  13805 x86_64-darwin
  23454 x86_64-linux

@mweinelt mweinelt force-pushed the home-assistant-on-3.12 branch 2 times, most recently from fd6917d to 512ec35 Compare February 23, 2024 12:30
@mweinelt
python312Pacakges.django: fix tests
5153865
@mweinelt
python312Packages.enocean: switch to pynose
dba0deb
@mweinelt
python312Packages.habitipy: switch to pynose
cb8b6de
@mweinelt
python312Packages.http-ece: refactor, switch tests to pynose
ee5173a 
Removed linters from checkInputs, normalized pname, remove python <3.8
compatibility
@mweinelt
python311Packages.influxdb: switch to pynose, disable and fix failing…
de50333 
… tests
@mweinelt
python312Packages.lark: disable tests
60fb5aa 
Js2py is not supported on 3.12.
@mweinelt
python312Packages.py-vapid: switch to pynose, remove linters from che…
a827b9d 
…ckInputs
@mweinelt
python312Packages.smmap: disable tests
11574c0 
Nosexcover is not supported on 3.12.
@mweinelt
python312Packages.statsd: disable tests, remove old patching
34a9920
@mweinelt
python312Packages.uncertainties: disable tests
24d4e25 
lib2to3 is not supported in setuptools since a longer time.
@mweinelt
python312Packages.uvcclient: switch to pynose, fix test
1d170e2
@mweinelt
python312Packages.youless-api: switch to pynose
27acc53
@mweinelt
python312Packages.lomond: disable failing test
6987e8c
@mweinelt
python312Packages.snitun: pep517 build, disable failing tests
05281dc
@mweinelt
python311Packages.xknx: fix pytest-asyncio 0.22 compat
adcdfe2 
and some light updates to dependency handling.
@mweinelt
python312Packages.airly: disable tests
8086e8f 
Aiounittest is not supported on 3.12.
@mweinelt
python312Packages.twilio: disable tests
4d3ee79 
Aiounittest is unsupported on 3.12.
@mweinelt
python312Packages.yalexs: disable tests
e48f6ee 
Aiounittest is unsupported on 3.12.
@mweinelt
python312Packages.pushbullet-py: disable failing tests
5bba46e 
and refactor, use pep 517 builder.
@mweinelt
python311Packages.gpiozero: 2.0 -> 2.0.1
2f77f5c 
https://github.com/gpiozero/gpiozero/blob/v2.0.1/docs/changelog.rst
@mweinelt
python312Packages.lingua: replace SafeConfigParser with ConfigParser
f96fa78 
The former is the removed alias for the latter.
@mweinelt
python311Packages.minio: 7.2.0 -> 7.2.4
7d619af 
https://github.com/minio/minio-py/releases/tag/7.2.1
https://github.com/minio/minio-py/releases/tag/7.2.2
https://github.com/minio/minio-py/releases/tag/7.2.3
https://github.com/minio/minio-py/releases/tag/7.2.4
@mweinelt
python312Packages.alarmdecoder: fix py3.12 compat
7ac9a1e
@mweinelt
python312Packages.fitbit: fix py3.12 compat
872ae70
@mweinelt
python312Packages.pyicloud: disable failing test
8c9e9cf 
and convert to pep517 build.
@mweinelt
python311Packages.odp-amsterdam: relax pytz constraint
ea191d7
@mweinelt
python312Packages.pysqueebox: disable failing test
854eab2
@mweinelt
python311Packages.pydiscovergy: relax pytz constraint
210e345
@mweinelt
python312Packages.bidict: 0.22.1 -> 0.23.1
81b96f9 
https://github.com/jab/bidict/blob/v0.23.1/CHANGELOG.rst
@mweinelt
python312Packages.django_5: fix tests
89656f0
@mweinelt mweinelt marked this pull request as draft February 24, 2024 03:01
@mweinelt mweinelt force-pushed the home-assistant-on-3.12 branch from 512ec35 to 89656f0 Compare February 24, 2024 03:01
@mweinelt mweinelt changed the base branch from staging-next to staging February 24, 2024 03:01
@github-actions github-actions bot added 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. and removed 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. labels Feb 24, 2024
@mweinelt mweinelt marked this pull request as ready for review February 24, 2024 03:02
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Feb 24, 2024
@mweinelt mweinelt merged commit 01b7290 into NixOS:staging Feb 24, 2024
@mweinelt mweinelt deleted the home-assistant-on-3.12 branch February 24, 2024 08:46
This was referenced Feb 27, 2024
Closed
Closed
@infinisil
Copy link
Member

infinisil commented Feb 29, 2024

Fyi, I believe the pkgs/by-name check failed due to the base branch change, probably staging-next didn't have #282707 yet or so. Shouldn't occur again in the future. Please ping me if you see the check failing though, it generally shouldn't be ignored, I'm continuously improving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mweinelt @infinisil @SuperSandro2000