Skip to content

pytestCheckHook: ignore warnings by default #292350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SuperSandro2000 wants to merge 2 commits into from
Closed

pytestCheckHook: ignore warnings by default #292350

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0da237c
pytestCheckHook: ignore warnings by default
SuperSandro2000 Feb 29, 2024
450d239
treewide: remove ignoring warnings from pytestFlagsArray
SuperSandro2000 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/development/interpreters/python/hooks/pytest-check-hook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ function pytestCheckPhase() {

# Compose arguments
args=" -m pytest"
if [ -n "$dontIgnoreWarnings-}" ]; then

@l0b0 l0b0 Nov 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads as "if not empty don't ignore warnings", which is a lot of negatives. Would if [ -z "$showWarnings-}" ] (which can be read as "if empty show warnings") be possible instead?

args+=" -W ignore::DeprecationWarning -W ignore::FutureWarning -W ignore::UserWarning"
fi

if [ -n "$disabledTests" ]; then
disabledTestsString=$(_pytestComputeDisabledTestsString "${disabledTests[@]}")
args+=" -k \""$disabledTestsString"\""
Expand Down