Skip to content

opencv4: 4.7.0 -> 4.9.0#289994

Merged
mweinelt merged 2 commits intoNixOS:masterfrom
mweinelt:opencv-4.9.0
Feb 25, 2024
Merged

opencv4: 4.7.0 -> 4.9.0#289994
mweinelt merged 2 commits intoNixOS:masterfrom
mweinelt:opencv-4.9.0

Conversation

@mweinelt
Copy link
Member

https://github.com/opencv/opencv/wiki/ChangeLog#version490

Description of changes

  • Supprt for Python 3.12
  • GStreamer support is now effectively limited by availability of elfutils, so no longer on darwin
  • VAAAPI support is now available on !darwin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from basvandijk February 19, 2024 18:25
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 19, 2024
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 20, 2024
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. and removed 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 20, 2024
@ofborg ofborg bot requested a review from D4ndellion February 24, 2024 10:06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


       >   Reason: tried: '/usr/local/lib/libopencv_calib3d.409.dylib' (no such file), '/usr/lib/libopencv_calib3d.409.dylib' (no such file, not in dyld cache)

I guess this only happens on darwin, shall we just ignore this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, is this a build time issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build time, the passthru tests, aarch64-darwin, as attempted by ofborg in the previous iteration

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails the same on master with 4.7.0. 🤷

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 25, 2024
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 25, 2024
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 25, 2024
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants