Draft
Conversation
This should hopefully prevent the crashes of unwrapped apps using GTK file chooser.
jtojnar
commented
Nov 29, 2023
| + g_autoptr(GSettingsSchemaSource) schema_source; | ||
| + g_autoptr(GSettingsSchema) schema; | ||
| + schema_source = g_settings_schema_source_new_from_directory("@gtk@", | ||
| + g_settings_schema_source_get_default(), |
Member
Author
There was a problem hiding this comment.
Since we are calling lookup with recursive=FALSE, the parent argument is actually pointless and can just be NULL.
jtojnar
commented
Nov 29, 2023
| prePatch = '' | ||
| substitute ${./patches/3.0-hardcode-gsettings.patch} hardcode-gsettings.patch \ | ||
| --subst-var-by gtk ${glib.makeSchemaPath "$out" "${finalAttrs.pname}-${finalAttrs.version}"} | ||
| patches="$patches $PWD/hardcode-gsettings.patch" |
jtojnar
commented
Nov 29, 2023
| + schema_source = g_settings_schema_source_new_from_directory("@gtk@", | ||
| + g_settings_schema_source_get_default(), | ||
| + TRUE, NULL); | ||
| + schema = g_settings_schema_source_lookup(schema_source, "org.gtk.Demo", |
Member
Author
There was a problem hiding this comment.
The default schema source is what implements overriding schema with environment variables so when we do not use it, the extraGSettingsOverrides NixOS option will be without effect.
We should probably tweak the patch to check the default schema first and only look in the hardcoded one when the schema is missing in the default one.
Member
|
Typo on "gsettinGs" |
ofborg
bot
requested review from
7c6f434c,
amaxine,
bobby285271,
dasj19 and
hedning
ofborg
bot
added
11.by: package-maintainer
Member
Can we then remove them from all the wrapper? |
Member
Author
Yeah, hopefully, this would make |
amaxine
changed the title
wegank
added
the
2.status: stale
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
stale
bot
removed
the
2.status: stale
13 tasks
wegank
added
the
2.status: stale
13 tasks
wegank
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
nixpkgs-ci
bot
added
the
2.status: stale
8 tasks
Closed
3 tasks
3 tasks
Member
|
This seems to be a bigger concern with the 25.11 and the gnome/gtk there. Can we revive this and merge it? |
nixpkgs-ci
bot
removed
the
2.status: stale
13 tasks
ilkecan
added a commit
to ilkecan/config
that referenced
this pull request
Feb 23, 2026
ilkecan
added a commit
to ilkecan/config
that referenced
this pull request
Feb 23, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This should hopefully prevent the crashes of unwrapped apps using GTK file chooser.
Fixes: #149812
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.