telegram-desktop: always wrap with wrapGAppsHook3

[NickCao]

Required for invoking the file selector

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[tpwrules]

Is there a way to globally do this? So many programs require this little hack and it's annoying to have to merge a PR for each one.

[NickCao]

Is there a way to globally do this?

That would negate the whole point of using nix: packages shouldn't require something to be installed globally.

So many programs require this little hack and it's annoying to have to merge a PR for each one.

Most of the programs are properly wrapped, this one was missed out during the last refactoring.

[tpwrules]

Sorry, I meant something like patching Glib or whichever library to have a default schema path, not a global install by the user or NixOS.

And I've personally had to file several, maybe the situation is better these days, but it seems there's always One More. Do you have a link to that refactoring?

[NickCao]

Sorry, I meant something like patching Glib or whichever library to have a default schema path, not a global install by the user or NixOS.

Ah, that sounds good! CC @jtojnar @bobby285271 for inputs.

And I've personally had to file several, maybe the situation is better these days, but it seems there's always One More. Do you have a link to that refactoring?

I'm referring to telegram-desktop refactoring: #353524

[jtojnar]

Ah, that sounds good! CC @jtojnar @bobby285271 for inputs.

See #271037. We still need to finish it up and do some testing.

[ilya-fedin]

That's wrong. The file selector is driven by QFileDialog. If this happens to tdesktop, this should happen to any other Qt application on the same system.

[jtojnar]

It does happen to any other Qt application on the same system.

[ilya-fedin]

I mean, why tdesktop is treated special here? Shouldn't this be done to Qt, QGnomePlatform or wrapQtAppsHook instead?

[NickCao]

That's wrong. The file selector is driven by QFileDialog. If this happens to tdesktop, this should happen to any other Qt application on the same system.

Oh this is on me, I'm forcing qt to use the gtk file selector by setting QT_QPA_PLATFORMTHEME to gtk3.

[jtojnar]

I mean, why tdesktop is treated special here?

It is not, other Qt apps are getting this treatment as well. Probably because it is not clear how to fix this properly so this hack tends spread.

Shouldn't this be done to Qt, QGnomePlatform or wrapQtAppsHook instead?

🤷‍♀️

[ilya-fedin]

It is not, other Qt apps are getting this treatment as well. Probably because it is not clear how to fix this properly so this hack tends spread.

Ah, ok