cura-appimage: init at 5.9.0#372614
Conversation
|
@bct, @FliegendeWurst, @nh2, you are welcome to test. |
4682f45 to
4eb66b1
Compare
|
Thank you, @FliegendeWurst! |
4eb66b1 to
1e35f80
Compare
1e35f80 to
8bc311d
Compare
|
@bct, you are not a nixpkgs maintainer yet! You need to add yourself to the nixpkgs maintainer list first. |
|
|
|
To get automatic updates diff --git a/pkgs/by-name/cu/cura-appimage/package.nix b/pkgs/by-name/cu/cura-appimage/package.nix
index c5b4f16297c9..8957584b3163 100644
--- a/pkgs/by-name/cu/cura-appimage/package.nix
+++ b/pkgs/by-name/cu/cura-appimage/package.nix
@@ -7,9 +7,10 @@
appimageTools,
copyDesktopItems,
makeDesktopItem,
+ nix-update-script,
}:
-let
+stdenvNoCC.mkDerivation rec {
pname = "cura-appimage";
version = "5.9.0";
@@ -52,9 +53,7 @@ let
done
QT_QPA_PLATFORM=xcb exec "${curaAppimageToolsWrapped}/bin/${appimageBinName}" "''${args[@]}"
'';
-in
-stdenvNoCC.mkDerivation rec {
- inherit pname version;
+
dontUnpack = true;
nativeBuildInputs = [ copyDesktopItems ];
@@ -107,6 +106,8 @@ stdenvNoCC.mkDerivation rec {
runHook postInstall
'';
+ passthru.updateScript = nix-update-script { extraArgs = [ "--version-regex=([56789].+)" ]; };
+
meta = {
description = "3D printing software";
homepage = "https://github.com/ultimaker/cura"; |
1eed196 to
5b2a71e
Compare
|
Thank you, @shimunn and @FliegendeWurst. |
|
Can't open an file:
crashes with the following terminal output, when clikcing on File -> Open file(s): |
|
I get the same error, but I can open files just fine. I set |
The is an similar recommendation in an Ultimaker forum post: Which works for me
If this flag is required for Cura to run on NixOs maybe we should set it via |
I had no issues running this on another machine (KDE Plasma) and opening a file...
But I also get this log output. No crash. |
|
Using it with |
|
Wow, you can even have the opposite crash with Qt apps. I tried |
|
This sort of crash might be fixed by #271037 eventually. For now we probably need the gappsWrapper |
I think if you also set |
5b2a71e to
58f8bd1
Compare
|
I added |
FliegendeWurst
left a comment
There was a problem hiding this comment.
Works for me, Plasma X11.
Would be good to test on a GTK-based desktop too.
Great, I tested on Plasma Wayland. |
|
@shimunn, do you have a GTK based desktop? |
I dont think so, I'm using i3 |
|
Do you still have the crash? |
Yes |
05d8900 to
c4f9b23
Compare
|
@shimunn, can you please try again? |
|
Anything missing here? |
|
@ofborg test cura-appimage |
d2898c2 to
3f76940
Compare
|
All done now. |
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
3f76940 to
d7e2aa0
Compare
|
Thank you very much! |
I took over #367409 (because there was no response anymore), matched the by-name path and added the desktop icon.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.