Skip to content

Comments

zpool-auto-expand-partitions: 0.1.0 -> 0.1.1#268562

Merged
cole-h merged 1 commit intoNixOS:masterfrom
cole-h:fixup-zpool-auto-expand-partitions
Nov 21, 2023
Merged

zpool-auto-expand-partitions: 0.1.0 -> 0.1.1#268562
cole-h merged 1 commit intoNixOS:masterfrom
cole-h:fixup-zpool-auto-expand-partitions

Conversation

@cole-h
Copy link
Member

@cole-h cole-h commented Nov 19, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This fixes the build with LLVM 16.
@cole-h cole-h force-pushed the fixup-zpool-auto-expand-partitions branch from 2e19f62 to 46b556c Compare November 19, 2023 19:31
@cole-h cole-h changed the title zpool-auto-expand-partitions: fixup build with LLVM 16 zpool-auto-expand-partitions: 0.1.0 -> 0.1.1 Nov 19, 2023
@ofborg ofborg bot requested review from Hoverbear, grahamc and lheckemann November 19, 2023 21:22
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 19, 2023
@cole-h
Copy link
Member Author

cole-h commented Nov 21, 2023

I don't typically like to self-merge, but since this was noticed by two separate parties (#268711, #263535 (comment)), and because this fixes the amazon ZFS image, I'm going to do just that.

@cole-h cole-h merged commit 042dce1 into NixOS:master Nov 21, 2023
@cole-h cole-h deleted the fixup-zpool-auto-expand-partitions branch November 21, 2023 01:17
@cole-h cole-h mentioned this pull request Nov 22, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant