llama-cpp: fix build due to openblas update; 1483 -> 1538#268449
Conversation
Contributor
|
LGTM |
elohmeier
approved these changes
Nov 19, 2023
Mic92
reviewed
Nov 19, 2023
Mic92
reviewed
Nov 19, 2023
added 2 commits
November 19, 2023 08:21
add patch so build checks for openblas64 module #255443 updated from openblas 0.3.21 -> 0.3.24. openblas 0.3.22 moved openblas.pc -> openblas64.pc OpenMathLib/OpenBLAS#3790
Author
|
thanks! |
Author
|
@elohmeier I had mistakenly assumed that the 64 was revering to pointer size when i made this change -- it doesn't. the 64 refers to the integer size, so is this package trying to use the ILP64 openblas or the LP64 openblas? the nix flake also uses the ILP64 openblas -- there was a comment |
Contributor
|
TBH I'm not using the OpenBLAS implementation personally and did not test it in depth. I don't really have an opinion on which one to use here, but would suggest to copy the upstream choice from their nix flake. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg-confg file for openblas moved from openblas.pc -> openblas64.pc
add patch so build checks for openblas64 module. submitted patch upstream ggml-org/llama.cpp#4134
#255443 updated from openblas 0.3.21 -> 0.3.24. openblas 0.3.22 moved openblas.pc -> openblas64.pc
OpenMathLib/OpenBLAS#3790
updated the package as well.
https://hydra.nixos.org/build/241259310
ZHF: #265948
Result of
nixpkgs-review pr 268449run on x86_64-linux 12 packages built:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)