Closed
Conversation
Contributor
Please update the modules hash. |
Author
Done. |
Contributor
I see your fix also added a merge commit. You should probably rebase against master instead. |
Author
Rebased! |
|
Any thoughts on updating to v0.1.10 instead? |
Author
|
Yes, but maybe after merging this?
…On Fri, Nov 17, 2023, 23:07 Ethan Thoma ***@***.***> wrote:
Any thoughts on updating to v0.1.10
<https://github.com/jmorganca/ollama/releases/tag/v0.1.10> instead?
—
Reply to this email directly, view it on GitHub
<#267486 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5EKR6TCQFD22CKTCYWKPTYE7GZLAVCNFSM6AAAAAA7LEV2D6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGEYDMMZWGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
I get a build error when running nixpkgs-review |
Member
|
Fixing the build failure would be gainful to the zero hydra fail campaign. |
Member
|
Seems to be fixed in #268449. LGTM, but could you @kirillrdy test on hardware? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)