Skip to content

openblas: 0.3.21 -> 0.3.24#255443

Merged
wegank merged 1 commit intoNixOS:stagingfrom
markuskowa:upd-openblas
Sep 29, 2023
Merged

openblas: 0.3.21 -> 0.3.24#255443
wegank merged 1 commit intoNixOS:stagingfrom
markuskowa:upd-openblas

Conversation

@markuskowa
Copy link
Member

@markuskowa markuskowa commented Sep 16, 2023

Description of changes

Versions 0.3.22 and 0.3.23 had build problems.
Changelog: https://github.com/xianyi/OpenBLAS/releases

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel September 16, 2023 09:02
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 16, 2023
@proofconstruction
Copy link
Contributor

proofconstruction commented Sep 26, 2023 •
edited
Loading

Build was failing on aarch64-darwin due to broken curl, but this was fixed by #255630.

With this change on the latest master staging, openblas builds fine on x86_64-linux, aarch64-linux, and aarch64-darwin.

This just needs a rebase and it's good to go.

@markuskowa
Copy link
Member Author

markuskowa commented Sep 26, 2023

@GrahamcOfBorg build openmolcas cp2k

@proofconstruction
Copy link
Contributor

proofconstruction commented Sep 26, 2023

The rebase builds successfully on aarch64-darwin and aarch64-linux.

@markuskowa
Copy link
Member Author

markuskowa commented Sep 29, 2023

Are we good to merge?

@wegank wegank merged commit 4e28463 into NixOS:staging Sep 29, 2023
@markuskowa markuskowa deleted the upd-openblas branch October 1, 2023 21:37
@ghost ghost mentioned this pull request Nov 19, 2023
Merged
13 tasks
Mic92 pushed a commit that referenced this pull request Nov 19, 2023
@Mic92
llama-cpp: fix build due to openblas update
05967f9 
add patch so build checks for openblas64 module

#255443 updated from openblas
0.3.21 -> 0.3.24.  openblas 0.3.22 moved openblas.pc -> openblas64.pc

OpenMathLib/OpenBLAS#3790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@r-burns r-burns Awaiting requested review from r-burns

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markuskowa @proofconstruction @wegank