makeOverridablePythonPackage: simplify implementation and make compatible with <pkg>.overrideAttrs#267296
Merged
ShamrockLee merged 3 commits intoNixOS:masterfrom Dec 10, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: python
ShamrockLee
changed the title
<pkg>.overridePythonAttrs work after <pkg>.overrideAttrs<pkg>.overridePythonAttrs work after <pkg>.overrideAttrs
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
2 times, most recently
from
205c377 to
2cf1c3c
Compare
ofborg
bot
added
10.rebuild-darwin: 0
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
2 times, most recently
from
e16c5f0 to
ac74756
Compare
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
from
ac74756 to
971cac5
Compare
This was referenced Dec 1, 2023
Contributor
Author
|
@ofborg build tests.overriding |
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
from
b2ebd09 to
7928373
Compare
wegank
added
the
2.status: stale
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
from
7928373 to
40ad5e6
Compare
Contributor
Author
|
I rebased the feature branch and resolved the merge conflict. |
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: merge conflict
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
from
40ad5e6 to
13aafb0
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
3 times, most recently
from
01dff07 to
c027f25
Compare
ShamrockLee
changed the title
<pkg>.overridePythonAttrs work after <pkg>.overrideAttrs<pkg>.overrideAttrs
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
from
c027f25 to
df82fae
Compare
Contributor
Author
|
Rebase and utilize PR #456848 ("tests.overriding: refactor and allow non-bool expected value"). |
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
3 times, most recently
from
e1001d7 to
303cf6f
Compare
Test with a pseudopackage python-package-stub. Modularize the transforming function and testing function.
Attach overridePythonAttrs by attribute set update instead of `stdenv.mkDerivation`'s `passthru`. Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
from
303cf6f to
898832f
Compare
Make it possible to mix overridePythonAttrs and overrideAttrs, i.e.
((<pkg>.overrideAttrs (_: { foo = "a"; })).overridePythonAttrs (_: { })).foo now works
Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
ShamrockLee
force-pushed
the
python-overrideattrs-fix
branch
from
898832f to
ca6c090
Compare
Contributor
Author
|
I wonder if it's okay to backport this PR, especially after the It should fix |
1 similar comment
Contributor
Author
|
I wonder if it's okay to backport this PR, especially after the It should fix |
MattSturgeon
approved these changes
Dec 10, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
I wonder if it's okay to backport this PR
I believe this should be fine to backport. It doesn't do anything too crazy.
Diff LGTM.
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This patch updates the
<pkg>.overrideAttrsinsidemakeOverridablePythonPackage(the function that adds<pkg>.overridePythonAttrs). If applied,<pkgs>.overridePythonAttrswill work after applying<pkg>.overrideAttrsto override a Python package built withbuildPythonPackageorbuildPythonApplication.This patch also adds corresponding test cases to
tests.overriding.Closes #267293.
Initial effort for #271387.
Cc: @FRidh
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)