Skip to content

[Backport release-25.11] makeOverridablePythonPackage: simplify implementation and make compatible with <pkg>.overrideAttrs#470091

Merged
MattSturgeon merged 3 commits intorelease-25.11from
backport-267296-to-release-25.11
Dec 12, 2025
Merged

[Backport release-25.11] makeOverridablePythonPackage: simplify implementation and make compatible with <pkg>.overrideAttrs#470091
MattSturgeon merged 3 commits intorelease-25.11from
backport-267296-to-release-25.11

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Dec 12, 2025

Bot-based backport to release-25.11, triggered by a label in #267296.

Before merging, ensure that this backport is acceptable for the release.

Even as a non-committer, if you find that it is not acceptable, leave a comment.

Tip

If you maintain all packages touched by this pull request, and they are all located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this PR using the nixpkgs-merge-bot.

ShamrockLee and others added 3 commits December 12, 2025 08:29
Test with a pseudopackage python-package-stub.

Modularize the transforming function and testing function.

(cherry picked from commit 1653d67)
Attach overridePythonAttrs by attribute set update
instead of `stdenv.mkDerivation`'s `passthru`.

Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
(cherry picked from commit e830243)
Make it possible to mix overridePythonAttrs and overrideAttrs, i.e.
((<pkg>.overrideAttrs (_: { foo = "a"; })).overridePythonAttrs (_: { })).foo now works

Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
(cherry picked from commit ca6c090)
@nixpkgs-ci nixpkgs-ci bot requested review from mweinelt and natsukium December 12, 2025 08:34
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. 4.workflow: backport This targets a stable branch labels Dec 12, 2025
@MattSturgeon MattSturgeon added this pull request to the merge queue Dec 12, 2025
Merged via the queue into release-25.11 with commit 27aa8c8 Dec 12, 2025
32 of 35 checks passed
@MattSturgeon MattSturgeon deleted the backport-267296-to-release-25.11 branch December 12, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants