treewide: deprecate pythonForBuild, replace with pythonOnBuildForHost#265764
Conversation
github-actions
bot
added
6.topic: python
ghost
changed the title
ghost
marked this pull request as ready for review
Artturin
reviewed
Nov 6, 2023
Artturin
reviewed
Nov 6, 2023
ofborg
bot
added
10.rebuild-darwin: 0
sigprof
added a commit
to sigprof/poetry2nix
that referenced
this pull request
Feb 1, 2024
The upstream Nixpkgs renamed `pythonForBuild` to `pythonOnBuildForHost` and made `pythonForBuild` emit warnings: NixOS/nixpkgs#265764. Adjust the poetry2nix code to avoid warnings with the new version, while still keeping compatibility with the old one.
This was referenced Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Deprecate confusing old name, add
lib.warn.See
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)