Skip to content

pyqtwebengine: use python.pythonOnBuildForHost#265570

Merged
Artturin merged 2 commits intomasterfrom
unknown repository
Nov 6, 2023
Merged

pyqtwebengine: use python.pythonOnBuildForHost#265570
Artturin merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Nov 5, 2023

Description of changes

When cross compiling, this commit causes pyqtwebengine to use
pythonOnBuildForHost rather than buildPackages.python3Packages,
so it will do the right thing when used with a non-default python
version.

As requested: #264965 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Nov 5, 2023
13 tasks
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 5, 2023
@ghost ghost marked this pull request as ready for review November 5, 2023 04:32
@ghost ghost requested a review from FRidh as a code owner November 5, 2023 04:32
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 5, 2023
@ghost ghost mentioned this pull request Nov 6, 2023
13 tasks
@Artturin Artturin merged commit 4f649d6 into NixOS:master Nov 6, 2023
@ghost ghost deleted the pyqtwebengine-take-different-python3 branch November 6, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant