Skip to content

Adjust for renaming of pythonForBuild to pythonOnBuildForHost#1521

Merged
cpcloud merged 1 commit into
nix-community:masterfrom
sigprof:pythonForBuild-deprecation
Feb 4, 2024
Merged

Adjust for renaming of pythonForBuild to pythonOnBuildForHost#1521
cpcloud merged 1 commit into
nix-community:masterfrom
sigprof:pythonForBuild-deprecation

Conversation

@sigprof
Copy link
Copy Markdown
Contributor

@sigprof sigprof commented Feb 1, 2024

The upstream Nixpkgs renamed pythonForBuild to pythonOnBuildForHost and made pythonForBuild emit warnings: NixOS/nixpkgs#265764. Adjust the poetry2nix code to avoid warnings with the new version, while still keeping compatibility with the old one.

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

The upstream Nixpkgs renamed `pythonForBuild` to `pythonOnBuildForHost`
and made `pythonForBuild` emit warnings: NixOS/nixpkgs#265764.  Adjust
the poetry2nix code to avoid warnings with the new version, while still
keeping compatibility with the old one.
@cpcloud cpcloud merged commit 3a3c802 into nix-community:master Feb 4, 2024
@cpcloud
Copy link
Copy Markdown
Contributor

cpcloud commented Feb 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants