Skip to content

qutebrowser: cleanup#265757

Merged
Artturin merged 2 commits intoNixOS:masterfrom
dotlambda:qutebrowser-cleanup
Nov 7, 2023
Merged

qutebrowser: cleanup#265757
Artturin merged 2 commits intoNixOS:masterfrom
dotlambda:qutebrowser-cleanup

Conversation

@dotlambda
Copy link
Member

Description of changes

Changes requested in #265364 were not made in #264965.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from a user November 6, 2023 00:43
@ofborg ofborg bot requested review from ebzzry, jagajaga, nrdxp and rnhmjoj November 6, 2023 01:21
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 6, 2023
@dotlambda dotlambda force-pushed the qutebrowser-cleanup branch 2 times, most recently from 5686e40 to cb1467d Compare November 6, 2023 01:55
@dotlambda dotlambda force-pushed the qutebrowser-cleanup branch from cb1467d to 2c6991d Compare November 6, 2023 02:56
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 6, 2023
@Artturin Artturin merged commit 8517efc into NixOS:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments