Closed
Conversation
12 tasks
Member
|
Triggering eval after it was fixed on master. @ofborg eval |
12 tasks
the latest changes skipped the postBuild hook which in turn would prevent the wrapping from being done
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
Author
|
Introducing "plugins" here might be too opiniated. Let's first introduce init.lua support and after 23.11 we can discuss this more calmly. |
12 tasks
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
Member
Author
|
equivalent merged in PR #344541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Follow up of #237425 (comment) .
WIP, creating it ahead of time just to have a reference when cloing other issues
Goal is to simplify the configuration of neovim. Right now we have several mechanisms to configure: override, wrapNeovim, makeNeovimConfig the latter being introduced by me but never documented as it didn't feel right. With the finalAttrs pattern we finally have self-documented parameters: launch a nix repl and explore neovim attributes, you can change them via overrideAttrs and they will automatically be taken into account.
And we can get rid of makeNeovimConfig: we can expose everything in the wrapper derivation: user customRc, the generatedRc etc. No need to find back the correct setting in the override call to adjust something down the line.
makeNeovimConfig will be kept for 23.11, not sure if it's going to be deprecated, depends how much time I can dedicate to this basically.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)