neovim: add withConfig function in passthru#223172
Closed
teto wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
TODO update doc
ofborg
bot
added
10.rebuild-darwin: 0
figsoda
reviewed
Mar 26, 2023
|
|
||
| passthru = { | ||
| # returns a wrapped neovim with everything needed | ||
| withConfig = callPackage ./wrapper.nix { } nvim; |
Member
There was a problem hiding this comment.
isn't this wrapNeovimUnstable instead of wrapNeovim?
Member
Author
There was a problem hiding this comment.
yes I would like to make wrapNeovimUnstable the default (the difference is you can pass plugins along with their config).
12 tasks
Member
Author
|
closing in favor of #257924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
instead of doing
wrapNeovim neovim-unwrapped config, one can doneovim-unwrapped.withConfig configwhich is more easily discoverable IMO.TODO update doc
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)