neovim: run hooks for build phase#260101
Merged
teto merged 1 commit intoNixOS:stagingfrom Oct 10, 2023
Merged
Conversation
the latest changes skipped the postBuild hook which in turn would prevent the wrapping from being done
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
Author
|
Merging because I fear the absence of this fix breaks is a worse outcome than whatever i've done here |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the latest changes skipped the postBuild hook which in turn would prevent the wrapping from being done and lead to a neovim apocalypse. I renamed the neovim input to neovim-unwrapped to make it clearer.
I've also exposed more stuff but the real big bang will come in #257924
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)