gnutar: pull missing libintl dependency on Darwin#244996
Merged
vcunat merged 1 commit intoNixOS:stagingfrom Jul 26, 2023
Merged
gnutar: pull missing libintl dependency on Darwin#244996vcunat merged 1 commit intoNixOS:stagingfrom
libintl dependency on Darwin#244996vcunat merged 1 commit intoNixOS:stagingfrom
Conversation
Contributor
Author
|
There is a caveat: on |
vcunat
reviewed
Jul 23, 2023
Without the change `gnutar` fails the build as:
"_libintl_setlocale", referenced from:
_main in tar.o
"_libintl_textdomain", referenced from:
_main in tar.o
ld: symbol(s) not found for architecture x86_64
https://hydra.nixos.org/build/228724258/nixlog/2/tail
https://hydra.nixos.org/build/228711328/nixlog/2/tail
trofi
force-pushed
the
gnutar-fix-on-darwin-libintl
branch
from
5e0cc4d to
e37a0e0
Compare
vcunat
pushed a commit
that referenced
this pull request
Jul 23, 2023
Without the change `gnutar` fails the build as:
"_libintl_setlocale", referenced from:
_main in tar.o
"_libintl_textdomain", referenced from:
_main in tar.o
ld: symbol(s) not found for architecture x86_64
https://hydra.nixos.org/build/228724258/nixlog/2/tail
https://hydra.nixos.org/build/228711328/nixlog/2/tail
Picked from PR #244996
ofborg
bot
added
10.rebuild-darwin-stdenv
vcunat
approved these changes
Jul 23, 2023
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
Looks good. And on staging-next-23.05 they now build fine for both *-darwin on Hydra.
Member
|
Maybe it's all non-Linux, but there's little practical difference for us and I don't have a way of trying (which is closely related). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
gnutarfails the build as:https://hydra.nixos.org/build/228724258/nixlog/2/tail https://hydra.nixos.org/build/228711328/nixlog/2/tail
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)