Skip to content

gnutar: pull missing libintl dependency on Darwin #244996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcunat merged 1 commit into from
Jul 26, 2023
Merged

gnutar: pull missing libintl dependency on Darwin #244996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkgs/tools/archivers/gnutar/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, stdenv, fetchurl, autoreconfHook, acl }:
{ lib, stdenv, fetchurl, autoreconfHook, acl, libintl }:

# Note: this package is used for bootstrapping fetchurl, and thus
# cannot use fetchpatch! All mutable patches (generated by GitHub or
Expand Down Expand Up @@ -31,7 +31,12 @@ stdenv.mkDerivation rec {
outputs = [ "out" "info" ];

nativeBuildInputs = lib.optional stdenv.isDarwin autoreconfHook;
buildInputs = lib.optional stdenv.isLinux acl;
# Add libintl on Darwin specifically as it fails to link (or skip)
# NLS on it's own:
# "_libintl_textdomain", referenced from:
# _main in tar.o
# ld: symbol(s) not found for architecture x86_64
buildInputs = lib.optional stdenv.isLinux acl ++ lib.optional stdenv.isDarwin libintl;

# May have some issues with root compilation because the bootstrap tool
# cannot be used as a login shell for now.
Expand Down