Skip to content

gnutar: 1.34 -> 1.35 #244293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jul 21, 2023
Merged

gnutar: 1.34 -> 1.35 #244293

1 commit merged into from
Jul 21, 2023

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jul 19, 2023 •
edited
Loading

Changes: https://lists.gnu.org/archive/html/info-gnu/2023-07/msg00005.html

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 19, 2023
ghost
ghost approved these changes Jul 20, 2023
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building on (will report any failures in the morning):

  • x86_64-linux workstation
  • powerpc64le-linux workstation
  • aarch64-linux laptop (cross from x86_64-linux)
  • mips64el-linux router (cross from x86_64-linux)

@ghost
Copy link

ghost commented Jul 21, 2023

The failure on aarch64-darwin is due to a timeout building LLVM:

error: building of '/nix/store/f55z96yl2ki5j60q3jkfjqkfgvwqv4ld-llvm-11.1.0.drv!out' from .drv file timed out after 3600 seconds

Everything built fine for me.

@ghost ghost merged commit 7edaa7b into NixOS:staging Jul 21, 2023
@trofi trofi deleted the gnutar-update branch July 21, 2023 09:35
@LeSuisse
Copy link
Member

LeSuisse commented Jul 22, 2023

Contains the fix for CVE-2022-48303.

@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one backport staging-23.05 labels Jul 22, 2023
@github-actions github-actions bot mentioned this pull request Jul 22, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

Successfully created backport PR for staging-23.05:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

Git push to origin failed for staging-23.05 with exitcode 1

@vcunat
Copy link
Member

vcunat commented Jul 23, 2023

It fails to build on *-darwin. At least on 23.05, but I don't expect it would differ.

@trofi
Copy link
Contributor Author

trofi commented Jul 23, 2023 

  "_libintl_setlocale", referenced from:
      _main in tar.o
  "_libintl_textdomain", referenced from:
      _main in tar.o
ld: symbol(s) not found for architecture x86_64

Might be easy to workaround with --disable-nls (or by adding gettext depend). Looking.

@trofi
Copy link
Contributor Author

trofi commented Jul 23, 2023

Proposed darwin fix as #244996 . THere is a caveat: on staging darwin is a bit broken for #244400 (comment) . I tested on staging-23.0.5. Builds fine.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trofi @LeSuisse @vcunat