Skip to content

python310Packages.aiohttp: unvendor llhttp#244541

Closed
dotlambda wants to merge 1 commit intoNixOS:stagingfrom
dotlambda:aiohttp-unvendor-llhttp
Closed

python310Packages.aiohttp: unvendor llhttp#244541
dotlambda wants to merge 1 commit intoNixOS:stagingfrom
dotlambda:aiohttp-unvendor-llhttp

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Jul 20, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from mweinelt July 20, 2023 18:35
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 20, 2023
@dotlambda dotlambda mentioned this pull request Jul 20, 2023
Merged
12 tasks
@dotlambda
Copy link
Member Author

dotlambda commented Jul 20, 2023 •
edited
Loading

Without downloading from GitHub and re-cythonizing everything, the test suite doesn't fail. However the path vendor/llhttp is hardcoded in the cythonized aiohttp/_cparser.c, so rm -r vendor leads to an error.
The error in the testsuite was simply related to 1970 timestamps.

@dotlambda dotlambda force-pushed the aiohttp-unvendor-llhttp branch from 92af280 to 65d4e87 Compare July 20, 2023 19:00
@dotlambda dotlambda marked this pull request as ready for review July 20, 2023 19:01
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 20, 2023
@dotlambda dotlambda force-pushed the aiohttp-unvendor-llhttp branch from 65d4e87 to 0f7db8d Compare July 23, 2023 18:43
@dotlambda
Copy link
Member Author

dotlambda commented Jul 26, 2023

@ofborg eval

@dotlambda
Copy link
Member Author

dotlambda commented Jul 28, 2023

@SuperSandro2000 @mweinelt Should this go into python-updates?

SuperSandro2000
SuperSandro2000 reviewed Jul 28, 2023
View reviewed changes
@dotlambda dotlambda force-pushed the aiohttp-unvendor-llhttp branch from 0f7db8d to 647fc30 Compare July 28, 2023 19:45
SuperSandro2000
SuperSandro2000 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-updates is over for now but I think we can just merge this into staging

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 6, 2023
@dotlambda
Copy link
Member Author

dotlambda commented Sep 9, 2023

python-updates is over for now but I think we can just merge this into staging

@mweinelt Do you agree?

@dotlambda dotlambda mentioned this pull request Oct 21, 2023
Merged
12 tasks
@dotlambda dotlambda mentioned this pull request Nov 21, 2023
Closed
13 tasks
@mweinelt
Copy link
Member

mweinelt commented Dec 2, 2023

Superseded by #268935.

@mweinelt mweinelt closed this Dec 2, 2023
@dotlambda dotlambda deleted the aiohttp-unvendor-llhttp branch December 2, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Python batch upgrade
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @mweinelt @SuperSandro2000 @wegank