Skip to content

python310Packages.aiohttp: 3.8.4 -> 3.8.5#244527

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
dotlambda:aiohttp-3.8.5
Jul 22, 2023
Merged

python310Packages.aiohttp: 3.8.4 -> 3.8.5#244527
vcunat merged 1 commit intoNixOS:stagingfrom
dotlambda:aiohttp-3.8.5

Conversation

@dotlambda
Copy link
Member

Description of changes

Changelog: https://github.com/aio-libs/aiohttp/blob/v3.8.5/CHANGES.rst

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added 1.severity: security Issues which raise a security issue, or PRs that fix one backport staging-23.05 labels Jul 20, 2023
@dotlambda dotlambda requested a review from mweinelt July 20, 2023 17:04
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 20, 2023
@mweinelt
Copy link
Member

Shouldn't we try and unvendor llhttp?

@dotlambda
Copy link
Member Author

Shouldn't we try and unvendor llhttp?

#244541

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 20, 2023
@vcunat vcunat merged commit 4ecd0a3 into NixOS:staging Jul 22, 2023
@github-actions
Copy link
Contributor

Backport failed for staging-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin staging-23.05
git worktree add -d .worktree/backport-244527-to-staging-23.05 origin/staging-23.05
cd .worktree/backport-244527-to-staging-23.05
git checkout -b backport-244527-to-staging-23.05
ancref=$(git merge-base 6ce03a2dbd383768be1b376e6229a32d38e1a6c0 f56fdf43e464c660e00d443bfc20c213f8118882)
git cherry-pick -x $ancref..f56fdf43e464c660e00d443bfc20c213f8118882

vcunat added a commit that referenced this pull request Jul 22, 2023
@vcunat
Copy link
Member

vcunat commented Jul 22, 2023

Backported to 23.05 manually.

@dotlambda dotlambda deleted the aiohttp-3.8.5 branch July 22, 2023 17:49
@happysalada
Copy link
Contributor

Just for information, not sure if it's relevant.
Upon testing a PR on staging, I kept getting failures for this package on linux-x86_64
I had to disable the file
"test_web_sendfile_functional.py"
that had 5 failures that were "ignored exception in ...".
Maybe that just happened on my local, but I'm leaving this for reference in case there are problems on staging later on.

@newAM
Copy link
Member

newAM commented Jul 27, 2023

I kept getting failures on x86_64-linux too, same test.
It's flakey, the package built on the 3rd try.

@happysalada
Copy link
Contributor

Ah we should disabled it at some point then.

@mweinelt
Copy link
Member

I did in afd84ee.

@happysalada
Copy link
Contributor

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants