Skip to content

python311Packages.aiohttp: 3.8.6 -> 3.9.1#268935

Closed
dotlambda wants to merge 6 commits intoNixOS:stagingfrom
dotlambda:aiohttp-3.9.0
Closed

python311Packages.aiohttp: 3.8.6 -> 3.9.1#268935
dotlambda wants to merge 6 commits intoNixOS:stagingfrom
dotlambda:aiohttp-3.9.0

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Nov 21, 2023 •
edited
Loading

Description of changes

Changelog: https://github.com/aio-libs/aiohttp/blob/v3.9.1/CHANGES.rst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

closes #244541

@dotlambda dotlambda requested review from mweinelt and tjni November 21, 2023 11:06
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 21, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 21, 2023
@ofborg ofborg bot requested a review from fabaff November 21, 2023 18:24
@ofborg ofborg bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 21, 2023
@dotlambda dotlambda marked this pull request as ready for review November 21, 2023 20:59
@dotlambda
Copy link
Member Author

dotlambda commented Nov 21, 2023

@mweinelt This breaks home-assistant.

@dotlambda dotlambda marked this pull request as draft November 21, 2023 21:56
@mweinelt
Copy link
Member

mweinelt commented Nov 21, 2023 •
edited
Loading 

pyproject.toml
26:    "aiohttp==3.9.0;python_version>='3.12'",
27:    "aiohttp==3.8.5;python_version<'3.12'",

I don't think we're ready for Python 3.12 just yet, but I might take a peek soon.

@ofborg ofborg bot requested a review from Mic92 November 22, 2023 02:52
@dotlambda
Copy link
Member Author

dotlambda commented Nov 22, 2023

Can't we patch their pyproject.toml such that we can use a newer aiohttp with Python 3.11?

@mweinelt
Copy link
Member

mweinelt commented Nov 30, 2023

3.9.1 has been released, and it will be required for #270457, where runtime dependency validation will become strict again.

@dotlambda dotlambda changed the title python311Packages.aiohttp: 3.8.6 -> 3.9.0 python311Packages.aiohttp: 3.8.6 -> 3.9.1 Nov 30, 2023
@mweinelt
Copy link
Member

mweinelt commented Dec 1, 2023

Rebased onto master and merged into #270457. Will carry that into python-updates soon.

@mweinelt mweinelt mentioned this pull request Dec 2, 2023
Closed
12 tasks
@mweinelt mweinelt closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@tjni tjni Awaiting requested review from tjni

@fabaff fabaff Awaiting requested review from fabaff

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dotlambda @mweinelt