libdatachannel: init at 0.18.5#237099
Conversation
ofborg
bot
added
8.has: package (new)
raphaelr
left a comment
raphaelr
left a comment
There was a problem hiding this comment.
Most feedback is about reducing vendoring
erdnaxe
changed the title
|
Using I am going to investigate why before continuing this PR. Thank you for the plog derivation, |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2368 |
Janik-Haag
left a comment
Janik-Haag
left a comment
There was a problem hiding this comment.
LGTM; I will merge this once some one else approves this as well or ~2 weeks go by with out some one complaining.
| let | ||
| # Use usrsctp version specified at https://github.com/paullouisageneau/libdatachannel/tree/master/deps | ||
| # Older or newer usrsctp might break libdatachannel, please keep it synced with upstream. | ||
| customUsrsctp = usrsctp.overrideAttrs (finalAttrs: previousAttrs: { |
There was a problem hiding this comment.
A more canonical name we would use would be usrsctp'
There was a problem hiding this comment.
we can revert this If you find it more then a slight annoyance.
There was a problem hiding this comment.
I can open another PR if you say this is important.
There was a problem hiding this comment.
Just keep it in mind for next time or the next change to this file
6 participants
Description of changes
Motivation: Next major version of OBS Studio will depend on libdatachannel for WHIP (WebRTC) support.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)